Multishot POC #36
Closed
Multishot POC #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare parameter upon `parameter` call
Pass HandlerPrompt through to ParameterizeState
Remove ParameterState.isDeclared and corresponding tests Remove ParameterState.getArgument in favour of the property argument
Delete irrelevant tests Ensure that only one single `runTest` is triggered per test, and that its result is returned
Restore hasBeenUsed status on each iteration Make DecoratorScope @RestrictsSuspension Remove unused ParameterState iteration functionality
Add ParameterizeDecorator Fix testing for empty iterations
Fix iteration count miscounting and add a test for it
…rd` and sequences to `channelFlow`
|
Closed in favour of #37 because I hadn't rebased correctly (oops) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
I have no expectation that this PR will be merged at all. This likely needs more design work, hence it's just a POC. I've made sure that there's near feature-compatibility, but of course the API had to change somewhat. The current version of kontinuity doesn't support Native because I haven't figured out how to shallow clone
Continuations yet (I haven't tried hard enough though, so suggestions are very welcome).I had to modify some of the tests that e.g. expected failures for things that are supported now. Also, tests for
parameterbeing used inside of aSequencecouldn't work anymore because of the usage ofsuspend, and hence they had to be removed.